chrome/renderer/resources/extensions/notifications_custom_bindings.js - Issue 12517011: Added activity logging for ext APIs with custom bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/notifications_custom_bindings.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Modified setHandleRequest to avoid double logging Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js ('K') | « chrome/renderer/resources/extensions/media_galleries_custom_bindings.js ('k') | chrome/renderer/resources/extensions/omnibox_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/page_action_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/notifications_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/notifications_custom_bindings.js b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

index d1dd6faad543e9a2679f03cf36a736444bd9a38a..15cad00c8578f61d50e28329b9e85476a9db4812 100644

--- a/chrome/renderer/resources/extensions/notifications_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

@@ -120,8 +120,8 @@ var handleUpdate = genHandle(function(callback, id) { callback(false); });

var notificationsCustomHook = function(bindingsAPI, extensionId) {

var apiFunctions = bindingsAPI.apiFunctions;

- apiFunctions.setHandleRequest('create', handleCreate);

- apiFunctions.setHandleRequest('update', handleCreate);

+ apiFunctions.setHandleRequest('create', handleCreate, false);

+ apiFunctions.setHandleRequest('update', handleCreate, false);

Matt Perry 2013/03/15 17:51:07 Both of these use sendRequest... sometimes. See ge

};

binding.registerCustomHook(notificationsCustomHook);