Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: chrome/renderer/resources/extensions/extension_custom_bindings.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modified setHandleRequest to avoid double logging Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/extension_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/extension_custom_bindings.js b/chrome/renderer/resources/extensions/extension_custom_bindings.js
index 2fe27775a79f98576970a83ff187f17a03a0e742..f92ef099753f7708e9e86a31cdec513016b26bf5 100644
--- a/chrome/renderer/resources/extensions/extension_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/extension_custom_bindings.js
@@ -51,24 +51,24 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
}
}
return GetExtensionViews(windowId, type) || null;
- });
+ }, false);
apiFunctions.setHandleRequest('getBackgroundPage', function() {
return GetExtensionViews(-1, 'BACKGROUND')[0] || null;
- });
+ }, false);
apiFunctions.setHandleRequest('getExtensionTabs', function(windowId) {
if (windowId == null)
windowId = WINDOW_ID_NONE;
return GetExtensionViews(windowId, 'TAB');
- });
+ }, false);
apiFunctions.setHandleRequest('getURL', function(path) {
path = String(path);
if (!path.length || path[0] != '/')
path = '/' + path;
return 'chrome-extension://' + extensionId + path;
- });
+ }, false);
// Alias several messaging deprecated APIs to their runtime counterparts.
var mayNeedAlias = [
@@ -98,7 +98,7 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
var port = chrome.runtime.connect(targetId || extensionId,
{name: chromeHidden.kRequestChannel});
chromeHidden.Port.sendMessageImpl(port, request, responseCallback);
- });
+ }, false);
Matt Perry 2013/03/15 17:51:07 This one is the messaging API - do you plan on log
felt 2013/03/15 23:26:15 FYI I have a separate CL pertaining to messaging t
if (sendRequestIsDisabled) {
extension.onRequest.addListener = function() {

Powered by Google App Engine
This is Rietveld 408576698