chrome/renderer/resources/extensions/browser_action_custom_bindings.js - Issue 12517011: Added activity logging for ext APIs with custom bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Modified setHandleRequest to avoid double logging Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/binding.js ('K') | « chrome/renderer/resources/extensions/bluetooth_custom_bindings.js ('k') | chrome/renderer/resources/extensions/context_menus_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/extension_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js b/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

index d90ab18235c3e7ac53f9429e0b8c9edc1c44ffa8..9bb9c31d20053e94dc84845ed1993fc14c7fe4e5 100644

--- a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

@@ -14,7 +14,7 @@ binding.registerCustomHook(function(bindingsAPI) {

apiFunctions.setHandleRequest('setIcon', function(details, callback) {

setIcon(details, callback, this.name, this.definition.parameters,

'browser action');

- });

+ }, false);

Matt Perry 2013/03/15 17:51:07 setIcon calls sendRequest behind the scenes... Con

});

exports.binding = binding.generate();