Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: chrome/browser/ui/chrome_bubble_manager.h

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybots pt2 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_bubble_manager.h
diff --git a/chrome/browser/ui/chrome_bubble_manager.h b/chrome/browser/ui/chrome_bubble_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..fa752219d8ad884366972e59f6c870bc7d4fb732
--- /dev/null
+++ b/chrome/browser/ui/chrome_bubble_manager.h
@@ -0,0 +1,29 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
+#define CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
+
+#include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
+#include "components/bubble/bubble_manager.h"
+
+class ChromeBubbleManager : public BubbleManager,
+ public TabStripModelObserver,
+ public base::SupportsWeakPtr<ChromeBubbleManager> {
msw 2015/08/26 01:42:35 Remove this if it's unused; nothing calls AsWeakPt
hcarmona 2015/08/26 17:25:58 Done.
+ public:
+ ChromeBubbleManager();
+ ~ChromeBubbleManager() override;
+
+ // TabStripModelObserver:
+ void TabDetachedAt(content::WebContents* contents, int index) override;
+ void TabDeactivated(content::WebContents* contents) override;
+
+ void WindowFullscreenStateChanged();
msw 2015/08/26 01:42:36 Do this with a WebContentsObserver::DidToggleFulls
hcarmona 2015/08/26 17:25:58 Done.
+ void NavigationEntryCommitted();
msw 2015/08/26 01:42:35 When is this ever called? Should this be a WebCont
hcarmona 2015/08/26 17:25:58 Done.
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManager);
+};
+
+#endif // CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698