Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/ui/chrome_bubble_manager.h

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybots pt2 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
6 #define CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
7
8 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
9 #include "components/bubble/bubble_manager.h"
10
11 class ChromeBubbleManager : public BubbleManager,
12 public TabStripModelObserver,
13 public base::SupportsWeakPtr<ChromeBubbleManager> {
msw 2015/08/26 01:42:35 Remove this if it's unused; nothing calls AsWeakPt
hcarmona 2015/08/26 17:25:58 Done.
14 public:
15 ChromeBubbleManager();
16 ~ChromeBubbleManager() override;
17
18 // TabStripModelObserver:
19 void TabDetachedAt(content::WebContents* contents, int index) override;
20 void TabDeactivated(content::WebContents* contents) override;
21
22 void WindowFullscreenStateChanged();
msw 2015/08/26 01:42:36 Do this with a WebContentsObserver::DidToggleFulls
hcarmona 2015/08/26 17:25:58 Done.
23 void NavigationEntryCommitted();
msw 2015/08/26 01:42:35 When is this ever called? Should this be a WebCont
hcarmona 2015/08/26 17:25:58 Done.
24
25 private:
26 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManager);
27 };
28
29 #endif // CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698