Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: components/bubble.gypi

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TESTS! Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bubble.gypi
diff --git a/components/browsing_data.gypi b/components/bubble.gypi
similarity index 55%
copy from components/browsing_data.gypi
copy to components/bubble.gypi
index c13a84a035868ba6caa6c5d5c06a370c6099332a..b9db0e991c881990659c46adf3656f3f2aa4d25c 100644
--- a/components/browsing_data.gypi
+++ b/components/bubble.gypi
@@ -5,20 +5,25 @@
{
'targets': [
msw 2015/08/21 01:48:30 Add a target for the unit tests here (in gyp) too.
hcarmona 2015/08/25 02:13:36 Most other tests in components don't do this. Is t
msw 2015/08/26 01:42:35 Ah, I see the pattern is to list unit tests source
{
- 'target_name': 'browsing_data',
+ # GN version: //components/bubble
+ 'target_name': 'bubble',
'type': 'static_library',
- 'dependencies': [
- '../base/base.gyp:base',
- '../content/content.gyp:content_browser',
- '../net/net.gyp:net',
- ],
'include_dirs': [
'..',
],
+ 'dependencies': [
+ '../content/content.gyp:content_browser',
+ '../ui/gfx/gfx.gyp:gfx',
+ ],
'sources': [
# Note: sources list duplicated in GN build.
- 'browsing_data/storage_partition_http_cache_data_remover.cc',
- 'browsing_data/storage_partition_http_cache_data_remover.h',
+ 'bubble/bubble_controller.cc',
+ 'bubble/bubble_controller.h',
+ 'bubble/bubble_delegate.cc',
+ 'bubble/bubble_delegate.h',
+ 'bubble/bubble_manager.cc',
+ 'bubble/bubble_manager.h',
+ 'bubble/bubble_ui.h',
],
},
],

Powered by Google App Engine
This is Rietveld 408576698