Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: components/bubble.gypi

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TESTS! Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
msw 2015/08/21 01:48:30 Add a target for the unit tests here (in gyp) too.
hcarmona 2015/08/25 02:13:36 Most other tests in components don't do this. Is t
msw 2015/08/26 01:42:35 Ah, I see the pattern is to list unit tests source
7 { 7 {
8 'target_name': 'browsing_data', 8 # GN version: //components/bubble
9 'target_name': 'bubble',
9 'type': 'static_library', 10 'type': 'static_library',
10 'dependencies': [
11 '../base/base.gyp:base',
12 '../content/content.gyp:content_browser',
13 '../net/net.gyp:net',
14 ],
15 'include_dirs': [ 11 'include_dirs': [
16 '..', 12 '..',
17 ], 13 ],
14 'dependencies': [
15 '../content/content.gyp:content_browser',
16 '../ui/gfx/gfx.gyp:gfx',
17 ],
18 'sources': [ 18 'sources': [
19 # Note: sources list duplicated in GN build. 19 # Note: sources list duplicated in GN build.
20 'browsing_data/storage_partition_http_cache_data_remover.cc', 20 'bubble/bubble_controller.cc',
21 'browsing_data/storage_partition_http_cache_data_remover.h', 21 'bubble/bubble_controller.h',
22 'bubble/bubble_delegate.cc',
23 'bubble/bubble_delegate.h',
24 'bubble/bubble_manager.cc',
25 'bubble/bubble_manager.h',
26 'bubble/bubble_ui.h',
22 ], 27 ],
23 }, 28 },
24 ], 29 ],
25 } 30 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698