chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kill views_bubble_controller Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/DEPS ('K') | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/website_settings/permission_bubble_delegate.h » ('j') | chrome/browser/ui/website_settings/permission_bubble_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index d15d167442d1064865842f59aece1cd559451adf..e806ddd1ad6258de4bc5620191d9fd38f3c846d0 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h"

+#include <vector>

#include "base/prefs/pref_service.h"

#include "base/strings/string16.h"

#include "chrome/browser/profiles/profile.h"

@@ -445,6 +447,7 @@ void PermissionBubbleViewViews::SetDelegate(Delegate* delegate) {

void PermissionBubbleViewViews::Show(

const std::vector<PermissionBubbleRequest*>& requests,

const std::vector<bool>& values) {

+ // TODO(hcarmona): refactor out the window/widget creation.

if (bubble_delegate_)

bubble_delegate_->Close();