Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4442)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_delegate.h

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Kill views_bubble_controller Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_delegate.h
diff --git a/chrome/browser/ui/website_settings/permission_bubble_delegate.h b/chrome/browser/ui/website_settings/permission_bubble_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..d6c2b6c5d76ca30e303a35d7f9141a71736732ea
--- /dev/null
+++ b/chrome/browser/ui/website_settings/permission_bubble_delegate.h
@@ -0,0 +1,38 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
please use gerrit instead 2015/07/22 23:56:09 Put this in anon namespace inside of the .cc file
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_DELEGATE_H_
+#define CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_DELEGATE_H_
+
+#include "chrome/browser/ui/website_settings/permission_bubble_view.h"
+#include "components/bubble/bubble_delegate.h"
+
+class Browser;
+class PermissionBubbleManager;
+
+class PermissionBubbleDelegate : public BubbleDelegate {
+ public:
+ PermissionBubbleDelegate(Browser* browser,
+ PermissionBubbleManager* permission_bubble_manager);
+ ~PermissionBubbleDelegate() override;
+
+ void OnShow() override;
please use gerrit instead 2015/07/22 23:56:09 // BubbleDelegate implementation.
+ void OnHide() override;
+
+ void OnUpdatePosition() override;
+
+ void BuildBubble(BubbleBuilder* builder) override;
+
+ private:
+ Browser* browser_;
+ PermissionBubbleManager* permission_bubble_manager_;
+
+ // TODO(hcarmona): Remove the view and factory after builder builds.
+ // Factory to be used to create views when needed.
+ PermissionBubbleView::Factory view_factory_;
+ // The UI surface to be used to display the permissions requests.
+ scoped_ptr<PermissionBubbleView> view_;
+};
+
+#endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698