Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Build Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index 601292ca3a3d2548cb49c6e0470683a9722e37b4..26d1e2546c95ca24835b7f6be88da646e4da9272 100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -1568,6 +1568,8 @@
'browser/ui/browser_view_prefs.h',
'browser/ui/browser_window_state.cc',
'browser/ui/browser_window_state.h',
+ 'browser/ui/chrome_bubble_manager.cc',
+ 'browser/ui/chrome_bubble_manager.h',
'browser/ui/chrome_pages.cc',
'browser/ui/chrome_pages.h',
'browser/ui/chrome_style.cc',
@@ -2818,6 +2820,7 @@
'chrome_web_ui_mojo_bindings.gyp:web_ui_mojo_bindings',
'debugger',
'installer_util',
+ '../components/bubble.gypi:bubble',
msw 2015/08/18 17:26:20 Does this belong in the ultimate ('OS!="android" a
hcarmona 2015/08/18 23:08:49 This should be views/cocoa independent. ChromeBubb
msw 2015/08/19 00:18:11 Right, but it shouldn't be expressed as a dependen
'../components/components.gyp:app_modal',
'../components/components.gyp:autofill_content_risk_proto',
'../components/components.gyp:translate_content_common',

Powered by Google App Engine
This is Rietveld 408576698