Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: chrome/browser/ui/chrome_bubble_manager.cc

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Build Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_bubble_manager.cc
diff --git a/chrome/browser/ui/chrome_bubble_manager.cc b/chrome/browser/ui/chrome_bubble_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..54caa212872abec248018805e976c8a2c77e77dc
--- /dev/null
+++ b/chrome/browser/ui/chrome_bubble_manager.cc
@@ -0,0 +1,54 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/chrome_bubble_manager.h"
+
+#include "content/public/browser/browser_thread.h"
+
+ChromeBubbleManager::ChromeBubbleManager() {}
+
+ChromeBubbleManager::~ChromeBubbleManager() {}
+
+void ChromeBubbleManager::FullscreenToggle() {
+ CloseAllBubbles(BUBBLE_CLOSE_FULLSCREEN);
+ // Any bubble that didn't close should update its anchor position.
+ UpdateAllBubbleAnchors();
+}
+
+void ChromeBubbleManager::TabBlur() {
+ CloseAllBubbles(BUBBLE_CLOSE_TABSWITCH);
+}
+
+void ChromeBubbleManager::TabFocus() {
hcarmona 2015/08/18 02:25:02 Does the bubble manager need to do anything when a
msw 2015/08/18 17:26:20 It shouldn't need to do anything, afaik.
hcarmona 2015/08/18 23:08:48 Then, I'll go ahead and remove this function. :-)
+ // TODO(hcarmona): What should bubbles do, if anything?
+}
+
+void ChromeBubbleManager::TabDetached() {
+ CloseAllBubbles(BUBBLE_CLOSE_TABDETACHED);
+ // Any bubble that didn't close should update its anchor position.
+ UpdateAllBubbleAnchors();
+}
+
+void ChromeBubbleManager::NavigationEntryCommitted() {
+ CloseAllBubbles(BUBBLE_CLOSE_NAVIGATION);
+}
+
+void ChromeBubbleManager::ShowBubbleUI(
+ base::WeakPtr<BubbleController> controller) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ BubbleManager::ShowBubbleUI(controller);
+}
+
+bool ChromeBubbleManager::ShouldClose(
+ base::WeakPtr<BubbleController> controller,
+ BubbleCloseReason reason) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ return BubbleManager::ShouldClose(controller, reason);
+}
+
+void ChromeBubbleManager::UpdateAnchorPosition(
+ base::WeakPtr<BubbleController> controller) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ BubbleManager::UpdateAnchorPosition(controller);
+}

Powered by Google App Engine
This is Rietveld 408576698