Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Build Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index befe5b85037b929614fa0d59510a954408011b3d..c20cfc09445e550630d3c5d29f79482dc2df3f45 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -809,6 +809,8 @@ void Browser::WindowFullscreenStateChanged() {
->WindowFullscreenStateChanged();
command_controller_->FullscreenStateChanged();
UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_TOGGLE_FULLSCREEN);
+
+ bubble_manager_.FullscreenToggle();
}
///////////////////////////////////////////////////////////////////////////////
@@ -990,6 +992,8 @@ void Browser::TabDetachedAt(WebContents* contents, int index) {
}
TabDetachedAtImpl(contents, index, DETACH_TYPE_DETACH);
+
+ bubble_manager_.TabDetached();
}
void Browser::TabDeactivated(WebContents* contents) {
@@ -1003,6 +1007,8 @@ void Browser::TabDeactivated(WebContents* contents) {
if (instant_controller_)
instant_controller_->TabDeactivated(contents);
+
+ bubble_manager_.TabBlur();
}
void Browser::ActiveTabChanged(WebContents* old_contents,
@@ -1087,6 +1093,8 @@ void Browser::ActiveTabChanged(WebContents* old_contents,
autofill::ChromeAutofillClient::FromWebContents(new_contents)->TabActivated();
SearchTabHelper::FromWebContents(new_contents)->OnTabActivated();
+
+ bubble_manager_.TabFocus();
}
void Browser::TabMoved(WebContents* contents,

Powered by Google App Engine
This is Rietveld 408576698