Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: components/bubble/bubble_ui.h

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/bubble/bubble_manager.cc ('K') | « components/bubble/bubble_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bubble/bubble_ui.h
diff --git a/components/bubble/bubble_ui.h b/components/bubble/bubble_ui.h
new file mode 100644
index 0000000000000000000000000000000000000000..ce4ca6c5240aac9c708605f3de180b3be6585aa3
--- /dev/null
+++ b/components/bubble/bubble_ui.h
@@ -0,0 +1,25 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_BUBBLE_BUBBLE_UI_H_
+#define COMPONENTS_BUBBLE_BUBBLE_UI_H_
+
+class BubbleUI {
+ public:
+ virtual ~BubbleUI() {}
msw 2015/08/13 03:37:23 nit: Should this be defined in a separate .cc file
hcarmona 2015/08/15 02:03:21 Done.
+
+ // Should display the bubble UI
msw 2015/08/13 03:37:23 nit: trailing period here and on the other functio
hcarmona 2015/08/15 02:03:21 Done.
+ virtual void Show() = 0;
+
+ // Should hide the bubble UI
+ virtual void Hide() = 0;
+
+ // Should update the bubble UI's position
+ virtual void UpdateAnchorPosition() = 0;
+
+ // Should return true if the bubble's contents can be updated.
msw 2015/08/13 03:37:23 As I mentioned before, I'm not entirely clear on w
hcarmona 2015/08/15 02:03:21 Acknowledged.
+ virtual bool CanAcceptUpdate() const = 0;
msw 2015/08/13 03:37:24 Consider finding common terminology between this a
hcarmona 2015/08/15 02:03:21 Acknowledged.
+};
+
+#endif // COMPONENTS_BUBBLE_BUBBLE_UI_H_
« components/bubble/bubble_manager.cc ('K') | « components/bubble/bubble_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698