Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/chrome_browser.gypi

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 920ef537263d25c6f0572ca63fa0f7d6886b1883..e56ec8352483e79bc2192b250faf9fe1fc34543a 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -3265,6 +3265,7 @@
'installer_util',
'../third_party/re2/re2.gyp:re2',
'../cc/cc.gyp:cc',
+ '../components/bubble.gypi:bubble',
msw 2015/08/13 03:37:21 This doesn't appear to be necessary (at least not
groby-ooo-7-16 2015/08/13 18:44:38 Don't we need this for the ChromeBubbleManager? It
msw 2015/08/13 19:18:58 That should be covered by chrome_browser_ui.gypi (
hcarmona 2015/08/13 20:50:35 Is there a tool to verify these?
'../components/components.gyp:autofill_content_browser',
'../components/components.gyp:browsing_data',
'../components/components.gyp:data_reduction_proxy_content_browser',

Powered by Google App Engine
This is Rietveld 408576698