Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/chrome_browser.gypi

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # All .cc, .h, .m, and .mm files under browser except for: 7 # All .cc, .h, .m, and .mm files under browser except for:
8 # * tests and mocks. 8 # * tests and mocks.
9 # * code below browser/chromeos 9 # * code below browser/chromeos
10 # * code below browser/extensions 10 # * code below browser/extensions
(...skipping 3247 matching lines...) Expand 10 before | Expand all | Expand 10 after
3258 ], 3258 ],
3259 'conditions': [ 3259 'conditions': [
3260 ['OS != "ios"', { 3260 ['OS != "ios"', {
3261 'dependencies': [ 3261 'dependencies': [
3262 'apps', 3262 'apps',
3263 'common_mojo_bindings', 3263 'common_mojo_bindings',
3264 'debugger', 3264 'debugger',
3265 'installer_util', 3265 'installer_util',
3266 '../third_party/re2/re2.gyp:re2', 3266 '../third_party/re2/re2.gyp:re2',
3267 '../cc/cc.gyp:cc', 3267 '../cc/cc.gyp:cc',
3268 '../components/bubble.gypi:bubble',
msw 2015/08/13 03:37:21 This doesn't appear to be necessary (at least not
groby-ooo-7-16 2015/08/13 18:44:38 Don't we need this for the ChromeBubbleManager? It
msw 2015/08/13 19:18:58 That should be covered by chrome_browser_ui.gypi (
hcarmona 2015/08/13 20:50:35 Is there a tool to verify these?
3268 '../components/components.gyp:autofill_content_browser', 3269 '../components/components.gyp:autofill_content_browser',
3269 '../components/components.gyp:browsing_data', 3270 '../components/components.gyp:browsing_data',
3270 '../components/components.gyp:data_reduction_proxy_content_browser', 3271 '../components/components.gyp:data_reduction_proxy_content_browser',
3271 '../components/components.gyp:devtools_discovery', 3272 '../components/components.gyp:devtools_discovery',
3272 '../components/components.gyp:devtools_http_handler', 3273 '../components/components.gyp:devtools_http_handler',
3273 '../components/components.gyp:dom_distiller_content_browser', 3274 '../components/components.gyp:dom_distiller_content_browser',
3274 '../components/components.gyp:favicon_content', 3275 '../components/components.gyp:favicon_content',
3275 '../components/components.gyp:guest_view_browser', 3276 '../components/components.gyp:guest_view_browser',
3276 '../components/components.gyp:history_content_browser', 3277 '../components/components.gyp:history_content_browser',
3277 '../components/components.gyp:keyed_service_content', 3278 '../components/components.gyp:keyed_service_content',
(...skipping 834 matching lines...) Expand 10 before | Expand all | Expand 10 after
4112 '../components/components.gyp:omnibox_browser', 4113 '../components/components.gyp:omnibox_browser',
4113 '../components/components.gyp:rlz', 4114 '../components/components.gyp:rlz',
4114 '../components/components.gyp:search_engines', 4115 '../components/components.gyp:search_engines',
4115 '../rlz/rlz.gyp:rlz_lib', 4116 '../rlz/rlz.gyp:rlz_lib',
4116 ], 4117 ],
4117 }, 4118 },
4118 ], 4119 ],
4119 }], 4120 }],
4120 ], 4121 ],
4121 } 4122 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698