Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1251463002: iOS factories for ProfileOAuth2TokenService and AccountTrackerService (Closed)

Created:
5 years, 5 months ago by droger
Modified:
5 years, 5 months ago
Reviewers:
sdefresne
CC:
browser-components-watch_chromium.org, chromium-reviews, noyau+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@componentizeOAuth2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

iOS factories for ProfileOAuth2TokenService and AccountTrackerService BUG=332107 Committed: https://crrev.com/40a232f3200451eeffc2d5e487c69de7e25606f1 Cr-Commit-Position: refs/heads/master@{#339693}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -30 lines) Patch
M ios/chrome/browser/enhanced_bookmarks/bookmark_server_cluster_service_factory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/history/web_history_service_factory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A ios/chrome/browser/signin/account_tracker_service_factory.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/account_tracker_service_factory.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/fake_oauth2_token_service_builder.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/fake_oauth2_token_service_builder.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/oauth2_token_service_factory.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/oauth2_token_service_factory.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 3 chunks +6 lines, -2 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/keyed_service_provider.h View 2 chunks +0 lines, -10 lines 0 comments Download
M ios/public/test/test_keyed_service_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/public/test/test_keyed_service_provider.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Depends on Patchset:

Issue 1245103005 Patch 1

Messages

Total messages: 8 (3 generated)
droger
5 years, 5 months ago (2015-07-21 13:56:43 UTC) #2
sdefresne
lgtm https://codereview.chromium.org/1251463002/diff/1/ios/chrome/browser/signin/account_tracker_service_factory.h File ios/chrome/browser/signin/account_tracker_service_factory.h (right): https://codereview.chromium.org/1251463002/diff/1/ios/chrome/browser/signin/account_tracker_service_factory.h#newcode25 ios/chrome/browser/signin/account_tracker_service_factory.h:25: // browser state (creating one if none exists). ...
5 years, 5 months ago (2015-07-21 14:29:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251463002/20001
5 years, 5 months ago (2015-07-21 17:52:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 18:01:55 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 18:02:56 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/40a232f3200451eeffc2d5e487c69de7e25606f1
Cr-Commit-Position: refs/heads/master@{#339693}

Powered by Google App Engine
This is Rietveld 408576698