Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1245103005: Componentize more signin code (Closed)

Created:
5 years, 5 months ago by droger
Modified:
5 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, Matt Giuca, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, yurys, tapted, plaree+watch_chromium.org, pam+watch_chromium.org, pfeldman, oshima+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org, bzanotti
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize more signin code This CL componentizes the preferences registration in AccountTrackerService, and FakeProfileOAuth2TokenService. This is a simple code move with no change in behavior. BUG=332107 TBR=jochen Committed: https://crrev.com/0c01726ff9b4e966a026aa65994d860f1041c128 Cr-Commit-Position: refs/heads/master@{#339688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -343 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/fake_invalidation_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/account_tracker_service_factory.cc View 2 chunks +1 line, -5 lines 0 comments Download
D chrome/browser/signin/fake_profile_oauth2_token_service.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/signin/fake_profile_oauth2_token_service.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M chrome/browser/signin/fake_profile_oauth2_token_service_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_tracker_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_refresh_token_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_auth_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/startup_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/fake_server_invalidation_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/speech_auth_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 5 chunks +4 lines, -6 lines 0 comments Download
M components/signin.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/signin/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/signin/core/browser/account_tracker_service.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/signin/core/browser/account_tracker_service.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A + components/signin/core/browser/fake_profile_oauth2_token_service.h View 3 chunks +4 lines, -5 lines 0 comments Download
A + components/signin/core/browser/fake_profile_oauth2_token_service.cc View 5 chunks +11 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
droger
CC bzanotti FYI rogerta: please review bauerb: for the dependency of components/signin on user_prefs
5 years, 5 months ago (2015-07-21 13:38:50 UTC) #2
Bernhard Bauer
DEPS change LGTM
5 years, 5 months ago (2015-07-21 14:31:01 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm This is awesome David! Thanks for doing this componentization.
5 years, 5 months ago (2015-07-21 17:15:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245103005/1
5 years, 5 months ago (2015-07-21 17:30:22 UTC) #6
droger
TBR=jochen for #include changes.
5 years, 5 months ago (2015-07-21 17:36:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 17:43:12 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:44:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c01726ff9b4e966a026aa65994d860f1041c128
Cr-Commit-Position: refs/heads/master@{#339688}

Powered by Google App Engine
This is Rietveld 408576698