Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 1251443002: ARM: make sure that the expected code size is computed in predictable scope. (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
Reviewers:
jbramley
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM: make sure that the expected code size is computed in predictable scope. BUG=v8:4277 LOG=NO Committed: https://crrev.com/5a556dfe314dbf818599c0f1b2886c733a94a086 Cr-Commit-Position: refs/heads/master@{#29772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ulan
Hi Jacob, would you mind taking a look?
5 years, 5 months ago (2015-07-21 09:57:36 UTC) #2
jbramley
What's the purpose of it? Will there be future cases where we don't know the ...
5 years, 5 months ago (2015-07-21 10:04:35 UTC) #3
ulan
On 2015/07/21 10:04:35, jbramley wrote: > What's the purpose of it? Will there be future ...
5 years, 5 months ago (2015-07-21 10:06:54 UTC) #4
jbramley
It might be more robust to be able to pass the flag to CallCodeSize(), and ...
5 years, 5 months ago (2015-07-21 10:11:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251443002/1
5 years, 5 months ago (2015-07-21 10:49:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 11:18:28 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 11:18:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a556dfe314dbf818599c0f1b2886c733a94a086
Cr-Commit-Position: refs/heads/master@{#29772}

Powered by Google App Engine
This is Rietveld 408576698