src/arm/lithium-codegen-arm.cc - Issue 1251443002: ARM: make sure that the expected code size is computed in predictable scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 1251443002: ARM: make sure that the expected code size is computed in predictable scope. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 04f6e6d9be480dd4703e9b8ef6317430cb3db021..a1534adb9b987ce6d074e1586b2d815024d1af1b 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -5801,8 +5801,8 @@ void LCodeGen::DoStackCheck(LStackCheck* instr) {

__ cmp(sp, Operand(ip));

__ b(hs, &done);

Handle<Code> stack_check = isolate()->builtins()->StackCheck();

- PredictableCodeSizeScope predictable(masm(),

- CallCodeSize(stack_check, RelocInfo::CODE_TARGET));

+ PredictableCodeSizeScope predictable(masm());

+ predictable.ExpectSize(CallCodeSize(stack_check, RelocInfo::CODE_TARGET));

DCHECK(instr->context()->IsRegister());

DCHECK(ToRegister(instr->context()).is(cp));

CallCode(stack_check, RelocInfo::CODE_TARGET, instr);

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/assembler.h » ('j') | no next file with comments »