Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 125133006: Mac: Disconnect DesktopMediaPicker window from the parent before closing (Closed)

Created:
6 years, 11 months ago by Sergey Ulanov
Modified:
6 years, 11 months ago
Reviewers:
Mark Mentovai, dcaiafa
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Mac: Disconnect DesktopMediaPicker window from the parent before closing The window wasn't removing itself from the parent's children list, which causes linked bug with some versions of Cocoa. BUG=331058 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243212

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
Official Chrome builds are compiled with a different SDK version (10.6), that's why I didn't ...
6 years, 11 months ago (2014-01-06 19:38:36 UTC) #1
dcaiafa
lgtm
6 years, 11 months ago (2014-01-06 19:44:16 UTC) #2
Mark Mentovai
LGTM As I recall, this is exactly what I asked about during the original review…
6 years, 11 months ago (2014-01-06 20:03:16 UTC) #3
Sergey Ulanov
On 2014/01/06 20:03:16, Mark Mentovai wrote: > LGTM > > As I recall, this is ...
6 years, 11 months ago (2014-01-06 20:14:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/125133006/30001
6 years, 11 months ago (2014-01-06 20:16:36 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 00:15:02 UTC) #6
Message was sent while issue was closed.
Change committed as 243212

Powered by Google App Engine
This is Rietveld 408576698