Set parent for window picker dialog on Mac

Set parent for window picker dialog on Mac

Initially DesktopMediaPicker::Show() didn't have parent parameter, 
so DesktopMediaPickerCococa wasn't setting parent for the window
it creates.

BUG=134249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242244

[Sergey Ulanov, 2013-12-20 21:01:19]

dcaiafa - please review
mark - please approve as an OWNER of chrome/browser/ui/cocoa

[Mark Mentovai, 2013-12-20 21:26:00]

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
(right):

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm:62:
NSTitledWindowMask | NSClosableWindowMask | NSResizableWindowMask;
Is this correct now that you might be creating a child window (if parent is
non-nil)?

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm:69:
[parent addChildWindow:window ordered:NSWindowAbove];
This should be inside the [super initWithWindow:] block below. If that fails,
|window| used to go out of scope and be deleted. The way you have it written
now, the parent window will still have a reference to a child window without a
controller.

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm:69:
[parent addChildWindow:window ordered:NSWindowAbove];
Do you ever want to remove this window from its parent? [[[self window]
parentWindow] removeChildWindow:self] somewhere?

[Sergey Ulanov, 2013-12-20 21:40:06]

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
(right):

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm:62:
NSTitledWindowMask | NSClosableWindowMask | NSResizableWindowMask;
On 2013/12/20 21:26:00, Mark Mentovai wrote:
> Is this correct now that you might be creating a child window (if parent is
> non-nil)?

I think it's still correct.

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm:69:
[parent addChildWindow:window ordered:NSWindowAbove];
On 2013/12/20 21:26:00, Mark Mentovai wrote:
> This should be inside the [super initWithWindow:] block below. If that fails,
> |window| used to go out of scope and be deleted. The way you have it written
> now, the parent window will still have a reference to a child window without a
> controller.

Done.

https://codereview.chromium.org/120253002/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm:69:
[parent addChildWindow:window ordered:NSWindowAbove];
On 2013/12/20 21:26:00, Mark Mentovai wrote:
> Do you ever want to remove this window from its parent? [[[self window]
> parentWindow] removeChildWindow:self] somewhere?

No, I don't think we need to remove it from parent anywhere.

[Mark Mentovai, 2013-12-20 22:07:10]

LGTM

[commit-bot: I haz the power, 2013-12-20 22:29:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/120253002/260001

[commit-bot: I haz the power, 2013-12-21 00:55:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/120253002/260001

[dcaiafa, 2013-12-21 01:01:18]

lgtm

[commit-bot: I haz the power, 2013-12-21 01:48:39]

Change committed as 242244