[Sync] Add ClearServerData support to Sync Scheduler

[Sync] Add ClearServerData support to Sync Scheduler

We must clear server data when transitioning to passphrase
encryption. Integrate the recently added ClearServerData RPC into
SyncScheduler.

BUG=490836
Committed: https://crrev.com/9cd186ef93973044b20388ab90d3673b2e2abc36
Cr-Commit-Position: refs/heads/master@{#340688}

[maniscalco, 2015-07-22 22:17:31]

maniscalco@chromium.org changed reviewers:
+ pavely@chromium.org, zea@chromium.org

[maniscalco, 2015-07-22 22:17:31]

Pavel, would you please review this change?

This is the next CL in the series for clearing server data when passphrase
encryption is enabled.

Nicolas, I've added you on the R line mostly as FYI, but your feedback is
appreciated if you've got spare cycles.

[pavely, 2015-07-27 19:45:05]

lgtm with 2 nits.

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/sync_schedu...
File sync/engine/sync_scheduler_impl.cc (right):

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/sync_schedu...
sync/engine/sync_scheduler_impl.cc:572:
pending_clear_params_->report_success_task.Run();
You can use RunAndReset here as well.

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/syncer.h
File sync/engine/syncer.h (right):

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/syncer.h#ne...
sync/engine/syncer.h:82: // Returns: false if an error occurred and retries
shoudl backoff, true
shoudl => should

[maniscalco, 2015-07-27 20:38:13]

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/sync_schedu...
File sync/engine/sync_scheduler_impl.cc (right):

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/sync_schedu...
sync/engine/sync_scheduler_impl.cc:572:
pending_clear_params_->report_success_task.Run();
On 2015/07/27 19:45:05, pavely wrote:
> You can use RunAndReset here as well.

RunAndReset isn't a perfect fit since here we need to reset the Params, not the
Closure.

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/syncer.h
File sync/engine/syncer.h (right):

https://codereview.chromium.org/1251203002/diff/60001/sync/engine/syncer.h#ne...
sync/engine/syncer.h:82: // Returns: false if an error occurred and retries
shoudl backoff, true
On 2015/07/27 19:45:05, pavely wrote:
> shoudl => should

Good catch.  Fixed.

[maniscalco, 2015-07-27 23:48:58]

The CQ bit was checked by maniscalco@chromium.org

[maniscalco, 2015-07-27 23:48:58]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/1251203002/#ps80001
(title: "Apply CR feedback")

[commit-bot: I haz the power, 2015-07-27 23:49:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251203002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251203002/80001

[commit-bot: I haz the power, 2015-07-28 00:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 00:06:54]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[maniscalco, 2015-07-28 15:20:35]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2015-07-28 15:21:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251203002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251203002/80001

[commit-bot: I haz the power, 2015-07-28 15:46:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-28 15:47:17]

Patchset 5 (id:??) landed as
https://crrev.com/9cd186ef93973044b20388ab90d3673b2e2abc36
Cr-Commit-Position: refs/heads/master@{#340688}