Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253743003: [Sync] Update SyncBackendHost to forward ClearServerData to SyncManager (Closed)

Created:
5 years, 5 months ago by maniscalco
Modified:
5 years, 4 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clearserverdatacommand
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Update SyncBackendHost to forward ClearServerData to SyncManager BUG=490836 Committed: https://crrev.com/f36ad019925b71a2d3e3cc8f60d95553e02ee0a6 Cr-Commit-Position: refs/heads/master@{#341022}

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Improve comments, fix test #

Patch Set 4 : Merge #

Total comments: 2

Patch Set 5 : Remove unused callback variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1 line) Patch
M chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 2 chunks +9 lines, -0 lines 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/sync_backup_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/sync_backup_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M sync/test/engine/fake_sync_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
maniscalco
Pavel, would you please review this change? It's the next in the series related to ...
5 years, 4 months ago (2015-07-28 16:17:02 UTC) #2
pavely
lgtm with one nit https://codereview.chromium.org/1253743003/diff/60001/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc File chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc (right): https://codereview.chromium.org/1253743003/diff/60001/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc#newcode806 chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc:806: syncer::SyncManager::ClearServerDataCallback callback; Callback is not ...
5 years, 4 months ago (2015-07-29 22:57:23 UTC) #3
maniscalco
https://codereview.chromium.org/1253743003/diff/60001/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc File chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc (right): https://codereview.chromium.org/1253743003/diff/60001/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc#newcode806 chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc:806: syncer::SyncManager::ClearServerDataCallback callback; On 2015/07/29 22:57:23, pavely wrote: > Callback ...
5 years, 4 months ago (2015-07-29 23:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253743003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253743003/80001
5 years, 4 months ago (2015-07-29 23:08:29 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-07-29 23:50:31 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 23:51:12 UTC) #9
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/f36ad019925b71a2d3e3cc8f60d95553e02ee0a6
Cr-Commit-Position: refs/heads/master@{#341022}

Powered by Google App Engine
This is Rietveld 408576698