Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1251043004: Revert of Only execute default actions on trusted events. (Closed)

Created:
5 years, 5 months ago by alancutter (OOO until 2018)
Modified:
5 years, 5 months ago
Reviewers:
tkent, dtapuska
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master_event_trusted_main3
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Only execute default actions on trusted events. (patchset #6 id:100001 of https://codereview.chromium.org/1234613004/) Reason for revert: This change is suspected to be causing the following failures on the Mac builders: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/1137 virtual/trustedeventsdefaultaction/fast/events/autoscroll.html virtual/trustedeventsdefaultaction/fast/events/context-no-deselect.html virtual/trustedeventsdefaultaction/fast/events/reveal-link-when-focused.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/42532 virtual/trustedeventsdefaultaction/fast/events/hit-test-cache-scrollbar-no-crash.html virtual/pointerevent/fast/events/hit-test-cache-scrollbar-no-crash.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/25157 fast/events/hit-test-cache-scrollbar-no-crash.html virtual/pointerevent/fast/events/hit-test-cache-scrollbar-no-crash.html Original issue's description: > Only execute default actions on trusted events. > > Add a RuntimeFeature to try out only allowing default actions to > execute on trusted events. > > This was previously tried in https://codereview.chromium.org/894913002 in > a slightly different approach; this attempt is based on the isTrusted > support. Also this time it is hidden behind a feature flag that > isn't enabled as it has some web compatibility issues that needs to > be quantified. > > BUG=334015 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199346 TBR=tkent@chromium.org,dtapuska@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=334015 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -160 lines) Patch
M LayoutTests/NeverFixTests View 3 chunks +0 lines, -12 lines 0 comments Download
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash.html View 1 chunk +3 lines, -6 lines 0 comments Download
D LayoutTests/fast/events/dispatch-synthetic-keyboardevent-no-action.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/events/dispatch-synthetic-keyboardevent-no-action-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/events/frame-tab-focus.html View 1 chunk +4 lines, -8 lines 0 comments Download
M LayoutTests/fast/events/option-tab.html View 2 chunks +6 lines, -8 lines 0 comments Download
M LayoutTests/fast/events/wheelevent-in-scrolling-div.html View 2 chunks +14 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/listbox-onchange.html View 1 chunk +33 lines, -31 lines 0 comments Download
M LayoutTests/fast/forms/range/slider-transformed.html View 2 chunks +11 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/range/slider-zoomed.html View 2 chunks +11 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/select-list-box-mouse-focus.html View 1 chunk +5 lines, -8 lines 0 comments Download
D LayoutTests/virtual/trustedeventsdefaultaction/fast/events/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/trustedeventsdefaultaction/fast/events/dispatch-synthetic-keyboardevent-no-action-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/trustedeventsdefaultaction/fast/events/simulated-key-state-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/events/EventDispatcher.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
alancutter (OOO until 2018)
Created Revert of Only execute default actions on trusted events.
5 years, 5 months ago (2015-07-23 07:23:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251043004/1
5 years, 5 months ago (2015-07-23 07:23:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199358
5 years, 5 months ago (2015-07-23 07:24:28 UTC) #3
tkent
lgtm
5 years, 5 months ago (2015-07-23 07:35:46 UTC) #4
dtapuska
5 years, 5 months ago (2015-07-23 13:12:53 UTC) #5
Message was sent while issue was closed.
On 2015/07/23 07:35:46, tkent wrote:
> lgtm

This change won't fix the failing builders for 10.6; that was actually caused by
a different change of mine that added that layout test for mac. I'm working on a
fix for that.

As for the two other failures on 10.10; they are exception cases that should be
handled in the TestExpectations (as they are special cased there there for
Yosemite)

Powered by Google App Engine
This is Rietveld 408576698