Issue 12510009: Merge 144894

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12510009: Merge 144894 (Closed)

Created:
7 years, 9 months ago by tony

Modified:
7 years, 9 months ago

Reviewers:
tony

CC:
chromium-reviews

Base URL:
https://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 144894 > Crash during middle mouse click when page is removed > https://bugs.webkit.org/show_bug.cgi?id=111489 > > Reviewed by Hajime Morrita. > > Source/WebCore: > > Check for a null page that can happen if we remove the document from the DOM. > The other methods in EventHandler also check for a null page. > > Test: editing/pasteboard/selection-paste-crash.html > > * page/EventHandler.cpp: > (WebCore::EventHandler::handlePasteGlobalSelection): > > LayoutTests: > > * editing/pasteboard/resources/selection-paste-crash.html: Added. > * editing/pasteboard/selection-paste-crash-expected.txt: Added. > * editing/pasteboard/selection-paste-crash.html: Added. > TBR=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145237

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -1066 lines)			Patch
M	LayoutTests/ChangeLog	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A +	LayoutTests/editing/pasteboard/resources/selection-paste-crash.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/editing/pasteboard/selection-paste-crash.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/editing/pasteboard/selection-paste-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/ChangeLog	View	1 chunk	+0 lines, -1069 lines	0 comments	Download
M	Source/WebCore/page/EventHandler.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r145237.

Expand Messages | Collapse Messages