build/config/ios/BUILD.gn - Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/ios/BUILD.gn

Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweaks needed to get base_unittests to compile Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/ios/BUILD.gn

diff --git a/build/config/ios/BUILD.gn b/build/config/ios/BUILD.gn

index 0539810f818dd46564a57cff05e4ca1a5723bd48..43bcdb3a781cfa15dc8d75badb2cfb780a4e96a9 100644

--- a/build/config/ios/BUILD.gn

+++ b/build/config/ios/BUILD.gn

@@ -9,13 +9,10 @@ config("sdk") {

common_flags = [

"-isysroot",

sysroot,

- ]

- if (use_ios_simulator) {

- common_flags += [ "-mios-simulator-version-min=$ios_deployment_target" ]

- } else {

- common_flags += [ "-miphoneos-version-min=$ios_deployment_target" ]

- }

+ # TODO(dpranke): Figure out why chinmay had this set. Needed on ios?

sdefresne 2015/07/24 08:47:31 Yes, iOS builds requires libc++ and c++11 and uses

Dirk Pranke 2015/07/31 21:27:40 Hm. Seems to work now. Will fix.

+ #"-stdlib=libc++",

+ ]

cflags = common_flags

ldflags = common_flags

« build/config/compiler/BUILD.gn ('K') | « build/config/features.gni ('k') | build/config/ios/find_signing_identity.py » ('j') | build/config/ios/find_signing_identity.py » ('J')