Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: build/config/ios/BUILD.gn

Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks needed to get base_unittests to compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sysroot.gni") 5 import("//build/config/sysroot.gni")
6 import("//build/config/ios/ios_sdk.gni") 6 import("//build/config/ios/ios_sdk.gni")
7 7
8 config("sdk") { 8 config("sdk") {
9 common_flags = [ 9 common_flags = [
10 "-isysroot", 10 "-isysroot",
11 sysroot, 11 sysroot,
12
13 # TODO(dpranke): Figure out why chinmay had this set. Needed on ios?
sdefresne 2015/07/24 08:47:31 Yes, iOS builds requires libc++ and c++11 and uses
Dirk Pranke 2015/07/31 21:27:40 Hm. Seems to work now. Will fix.
14 #"-stdlib=libc++",
12 ] 15 ]
13 16
14 if (use_ios_simulator) {
15 common_flags += [ "-mios-simulator-version-min=$ios_deployment_target" ]
16 } else {
17 common_flags += [ "-miphoneos-version-min=$ios_deployment_target" ]
18 }
19
20 cflags = common_flags 17 cflags = common_flags
21 ldflags = common_flags 18 ldflags = common_flags
22 } 19 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698