Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc

Issue 1250613002: scheduler: Remove task observer shenanigans (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a failing test. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
diff --git a/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc b/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
index 9d613d65965a0b43555abce8a7a55cfc25c2098b..23c69978402bf982ee9fdd0a986e376b11a273f7 100644
--- a/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
+++ b/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
@@ -33,10 +33,6 @@ base::MessageLoop* LazySchedulerMessageLoopDelegateForTests::EnsureMessageLoop()
message_loop_ = base::MessageLoop::current();
DCHECK(message_loop_);
original_task_runner_ = message_loop_->task_runner();
- for (auto& observer : pending_observers_) {
- message_loop_->AddTaskObserver(observer);
- }
- pending_observers_.clear();
if (pending_task_runner_)
message_loop_->SetTaskRunner(pending_task_runner_.Pass());
return message_loop_;
@@ -86,22 +82,4 @@ bool LazySchedulerMessageLoopDelegateForTests::IsNested() const {
return EnsureMessageLoop()->IsNested();
}
-void LazySchedulerMessageLoopDelegateForTests::AddTaskObserver(
- base::MessageLoop::TaskObserver* task_observer) {
- if (!HasMessageLoop()) {
- pending_observers_.insert(task_observer);
- return;
- }
- EnsureMessageLoop()->AddTaskObserver(task_observer);
-}
-
-void LazySchedulerMessageLoopDelegateForTests::RemoveTaskObserver(
- base::MessageLoop::TaskObserver* task_observer) {
- if (!HasMessageLoop()) {
- pending_observers_.erase(task_observer);
- return;
- }
- EnsureMessageLoop()->RemoveTaskObserver(task_observer);
-}
-
} // namespace scheduler
« no previous file with comments | « components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698