components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h - Issue 1250613002: scheduler: Remove task observer shenanigans

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h

Issue 1250613002: scheduler: Remove task observer shenanigans (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a failing test. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc ('k') | components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h

diff --git a/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h b/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h

index 5f2eaec2e78db34f816378193c7d75498a25eb62..aaffb916881e30c5a3fa875751260113c308a18c 100644

--- a/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h

+++ b/components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h

@@ -34,9 +34,6 @@ class LazySchedulerMessageLoopDelegateForTests

base::TimeDelta delay) override;

bool RunsTasksOnCurrentThread() const override;

bool IsNested() const override;

- void AddTaskObserver(base::MessageLoop::TaskObserver* task_observer) override;

- void RemoveTaskObserver(

- base::MessageLoop::TaskObserver* task_observer) override;

private:

LazySchedulerMessageLoopDelegateForTests();

@@ -48,10 +45,6 @@ class LazySchedulerMessageLoopDelegateForTests

mutable base::MessageLoop* message_loop_;

base::PlatformThreadId thread_id_;

- // Task observers which have not yet been registered to a message loop. Not

- // owned.

- mutable base::hash_set<base::MessageLoop::TaskObserver*> pending_observers_;

// A task runner which hasn't yet been overridden in the message loop.

mutable scoped_refptr<base::SingleThreadTaskRunner> pending_task_runner_;

mutable scoped_refptr<base::SingleThreadTaskRunner> original_task_runner_;