Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1250613002: scheduler: Remove task observer shenanigans (Closed)

Created:
5 years, 5 months ago by Sami
Modified:
5 years, 5 months ago
CC:
chromium-reviews, scheduler-bugs_chromium.org, rmcilroy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Remove task observer shenanigans Now that tasks posted to the message loop are routed through the scheduler, there's no need for the scheduler to listen for task observer notifications from the message loop or coalesce them into a mostly consistent stream of notifications to downstream observers. BUG=444764 Committed: https://crrev.com/e1ab6c84cbadc16f4d5d775e1ab3680fe0af2612 Cr-Commit-Position: refs/heads/master@{#339654}

Patch Set 1 #

Patch Set 2 : Fixed a failing test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -148 lines) Patch
M components/scheduler/child/idle_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/nestable_single_thread_task_runner.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/scheduler/child/nestable_task_runner_for_test.h View 2 chunks +0 lines, -10 lines 0 comments Download
M components/scheduler/child/nestable_task_runner_for_test.cc View 2 chunks +3 lines, -34 lines 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate_for_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate_for_test.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/scheduler/child/scheduler_task_runner_delegate_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M components/scheduler/child/task_queue_manager.h View 1 chunk +5 lines, -6 lines 0 comments Download
M components/scheduler/child/task_queue_manager.cc View 5 chunks +8 lines, -16 lines 0 comments Download
M components/scheduler/child/task_queue_manager_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc View 6 chunks +0 lines, -16 lines 0 comments Download
M components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h View 2 chunks +0 lines, -7 lines 0 comments Download
M components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sami
5 years, 5 months ago (2015-07-21 10:31:43 UTC) #2
alex clarke (OOO till 29th)
lgtm
5 years, 5 months ago (2015-07-21 10:43:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250613002/1
5 years, 5 months ago (2015-07-21 10:46:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/40724)
5 years, 5 months ago (2015-07-21 11:18:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250613002/20001
5 years, 5 months ago (2015-07-21 14:26:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 15:27:46 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 15:28:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1ab6c84cbadc16f4d5d775e1ab3680fe0af2612
Cr-Commit-Position: refs/heads/master@{#339654}

Powered by Google App Engine
This is Rietveld 408576698