chrome/browser/ui/cocoa/browser_window_utils.mm - Issue 1250533003: [Mac] Remove BrowserCommandExecutor protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_utils.mm

Issue 1250533003: [Mac] Remove BrowserCommandExecutor protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't take a window for handleExtraKeyboardShortcut. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_utils.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_utils.mm b/chrome/browser/ui/cocoa/browser_window_utils.mm

index 60dd4d1f8827371fc63ecfb3f2469b5eef29e278..2a63941522accefc8ddb13b11d8cbcad7934f496 100644

--- a/chrome/browser/ui/cocoa/browser_window_utils.mm

+++ b/chrome/browser/ui/cocoa/browser_window_utils.mm

@@ -45,13 +45,7 @@ using content::NativeWebKeyboardEvent;

if ([[NSApp mainMenu] performKeyEquivalent:event])

return true;

- if ([event_window handleExtraBrowserKeyboardShortcut:event])

- return true;

- if ([event_window handleExtraWindowKeyboardShortcut:event])

- return true;

- if ([event_window handleDelayedWindowKeyboardShortcut:event])

+ if ([event_window handleExtraKeyboardShortcut:event])

return true;

}