chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 1250533003: [Mac] Remove BrowserCommandExecutor protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1250533003: [Mac] Remove BrowserCommandExecutor protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't take a window for handleExtraKeyboardShortcut. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index cb00583f131f285a812f02325fc9e05c07bdadcd..6e87b171a020e0beac28106454bb76c9a938eab2 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1264,12 +1264,6 @@ using content::WebContents;

[NSApp currentEvent], modifierFlags));

}

-// Called when another part of the internal codebase needs to execute a

-// command.

-- (void)executeCommand:(int)command {

- chrome::ExecuteCommand(browser_.get(), command);

- (BOOL)handledByExtensionCommand:(NSEvent*)event

priority:(ui::AcceleratorManager::HandlerPriority)priority {

return extension_keybinding_registry_->ProcessKeyEvent(