Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1250513004: [es6] Make sure temporaries are not allocated in block scope (Closed)

Created:
5 years, 5 months ago by rossberg
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Make sure temporaries are not allocated in block scope While at it, remove the notion of INTERNAL variables. @caitp: Took some parts from your CL, since I was blocked on the temp scope bug. R=mstarzinger@chromium.org BUG=512574 LOG=N Committed: https://crrev.com/9ab8bfba7fe237709d0ba3dc0c6acbf0653beab7 Cr-Commit-Position: refs/heads/master@{#29812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -47 lines) Patch
M src/contexts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/globals.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parser.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/pattern-rewriter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/scopeinfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/scopes.cc View 4 chunks +14 lines, -16 lines 0 comments Download
M src/variables.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-cr512574.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rossberg
5 years, 5 months ago (2015-07-23 12:54:07 UTC) #1
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-23 13:25:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250513004/1
5 years, 5 months ago (2015-07-23 13:25:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4398)
5 years, 5 months ago (2015-07-23 13:29:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250513004/1
5 years, 5 months ago (2015-07-23 13:32:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 13:51:32 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 13:51:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ab8bfba7fe237709d0ba3dc0c6acbf0653beab7
Cr-Commit-Position: refs/heads/master@{#29812}

Powered by Google App Engine
This is Rietveld 408576698