Issue 125043006: Fix building d8 with readline support due to API changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125043006: Fix building d8 with readline support due to API changes (Closed)

Created:
6 years, 11 months ago by Adrian Perez de Castro

Modified:
6 years, 11 months ago

Reviewers:
Benedikt Meurer, Yang, Michael Starzinger

CC:
v8-dev

Visibility:
Public.

Fix building d8 with readline support due to API changes After recent API changes, d8 will fail to build when passing "console=readline". This patch makes d8 work with readline again. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18457

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/d8-readline.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Committed patchset #1 manually as r18457 (presubmit successful).

6 years, 11 months ago (2014-01-07 07:53:25 UTC) #3

Sven Panne

6 years, 11 months ago (2014-01-07 07:58:38 UTC) #4

Message was sent while issue was closed.

@machenbach: I thought we have a builder with readline support enabled, so this
should have been caught by our waterfall. Did I miss something?