Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 125043006: Fix building d8 with readline support due to API changes (Closed)

Created:
6 years, 11 months ago by Adrian Perez de Castro
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix building d8 with readline support due to API changes After recent API changes, d8 will fail to build when passing "console=readline". This patch makes d8 work with readline again. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/d8-readline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Adrian Perez de Castro
6 years, 11 months ago (2014-01-06 22:44:10 UTC) #1
Benedikt Meurer
LGTM, I'll land it.
6 years, 11 months ago (2014-01-07 07:52:59 UTC) #2
Benedikt Meurer
Committed patchset #1 manually as r18457 (presubmit successful).
6 years, 11 months ago (2014-01-07 07:53:25 UTC) #3
Sven Panne
6 years, 11 months ago (2014-01-07 07:58:38 UTC) #4
Message was sent while issue was closed.
@machenbach: I thought we have a builder with readline support enabled, so this
should have been caught by our waterfall. Did I miss something?

Powered by Google App Engine
This is Rietveld 408576698