Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Side by Side Diff: src/d8-readline.cc

Issue 125043006: Fix building d8 with readline support due to API changes (Closed)
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 rl_point); 156 rl_point);
157 completions = Shell::GetCompletions(isolate, 157 completions = Shell::GetCompletions(isolate,
158 String::NewFromUtf8(isolate, text), 158 String::NewFromUtf8(isolate, text),
159 full_text); 159 full_text);
160 current_completions.Reset(isolate, completions); 160 current_completions.Reset(isolate, completions);
161 current_index = 0; 161 current_index = 0;
162 } else { 162 } else {
163 completions = Local<Array>::New(isolate, current_completions); 163 completions = Local<Array>::New(isolate, current_completions);
164 } 164 }
165 if (current_index < completions->Length()) { 165 if (current_index < completions->Length()) {
166 Handle<Integer> index = Integer::New(current_index); 166 Handle<Integer> index = Integer::New(isolate, current_index);
167 Handle<Value> str_obj = completions->Get(index); 167 Handle<Value> str_obj = completions->Get(index);
168 current_index++; 168 current_index++;
169 String::Utf8Value str(str_obj); 169 String::Utf8Value str(str_obj);
170 return strdup(*str); 170 return strdup(*str);
171 } else { 171 } else {
172 current_completions.Reset(); 172 current_completions.Reset();
173 return NULL; 173 return NULL;
174 } 174 }
175 } 175 }
176 #endif // V8_SHARED 176 #endif // V8_SHARED
177 177
178 178
179 } // namespace v8 179 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698