ui/views/cocoa/native_widget_mac_nswindow.h - Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/native_widget_mac_nswindow.h

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Sync Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_frame_mac.mm ('K') | « ui/base/cocoa/command_dispatcher.h ('k') | ui/views/cocoa/native_widget_mac_nswindow.mm » ('j') | ui/views/cocoa/native_widget_mac_nswindow.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/cocoa/native_widget_mac_nswindow.h

diff --git a/ui/views/cocoa/native_widget_mac_nswindow.h b/ui/views/cocoa/native_widget_mac_nswindow.h

index adc6b04169316175b57640eb7847bff2a8268081..a43b979d4e5eda25c0f984f9026d694564f2d4fd 100644

--- a/ui/views/cocoa/native_widget_mac_nswindow.h

+++ b/ui/views/cocoa/native_widget_mac_nswindow.h

@@ -13,11 +13,17 @@

// The NSWindow used by BridgedNativeWidget. Provides hooks into AppKit that

// can only be accomplished by overriding methods.

VIEWS_EXPORT

-@interface NativeWidgetMacNSWindow : NSWindow<CommandDispatchingWindow>

+@interface NativeWidgetMacNSWindow

+ : NSWindow<CommandDispatchingWindow, NSUserInterfaceValidations>

tapted 2015/09/03 04:15:38 same here - NSUserInterfaceValidations is redundan

jackhou1 2015/09/03 06:15:39 Done.

// Set a CommandDispatcherDelegate, i.e. to implement key event handling.

- (void)setCommandDispatcherDelegate:(id<CommandDispatcherDelegate>)delegate;

+// Set a UserInterfaceItemCommandHandler to validate UI items and execute

+// commands.

+- (void)setUserInterfaceItemCommandHandler:

+ (id<UserInterfaceItemCommandHandler>)commandHandler;

@end

#endif // UI_VIEWS_COCOA_NATIVE_WIDGET_MAC_NSWINDOW_H_