chrome/browser/ui/views/frame/browser_frame_mac.mm - Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_frame_mac.mm

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Sync Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/chrome_event_processing_window.mm ('K') | « chrome/browser/ui/cocoa/chrome_event_processing_window.mm ('k') | ui/base/cocoa/command_dispatcher.h » ('j') | ui/views/cocoa/native_widget_mac_nswindow.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_frame_mac.mm

diff --git a/chrome/browser/ui/views/frame/browser_frame_mac.mm b/chrome/browser/ui/views/frame/browser_frame_mac.mm

index cd705a40a9a22b67959a34aae7d8dd37a299554f..1da9ded08ec3744f02717e8d103c7fce25f541e6 100644

--- a/chrome/browser/ui/views/frame/browser_frame_mac.mm

+++ b/chrome/browser/ui/views/frame/browser_frame_mac.mm

@@ -70,6 +70,7 @@ NativeWidgetMacNSWindow* BrowserFrameMac::CreateNSWindow(

backing:NSBackingStoreBuffered

defer:NO]);

[ns_window setCommandDispatcherDelegate:command_dispatcher_delegate_];

+ [ns_window setUserInterfaceItemCommandHandler:command_dispatcher_delegate_];

tapted 2015/09/03 04:15:38 can NativeWidgetMacNSWindow assume these are alway

jackhou1 2015/09/03 06:15:39 Done.

return ns_window.autorelease();

}