[Mac] Move UI item validation to UserInterfaceItemCommandHandler.

ui/views/cocoa/native_widget_mac_nswindow.mm

Index: ui/views/cocoa/native_widget_mac_nswindow.mm
diff --git a/ui/views/cocoa/native_widget_mac_nswindow.mm b/ui/views/cocoa/native_widget_mac_nswindow.mm
index 04d784971b6013d39b99685f10c80469a7df6473..a14550ff8c8a3e41ef282f270075ed5085bf3d21 100644
--- a/ui/views/cocoa/native_widget_mac_nswindow.mm
+++ b/ui/views/cocoa/native_widget_mac_nswindow.mm
@@ -157,6 +157,8 @@
 
 // CommandDispatcher implementation.
 
+@synthesize commandHandler;
+
 - (BOOL)redispatchKeyEvent:(NSEvent*)event {
   return [commandDispatcher_ redispatchKeyEvent:event];
 }
@@ -165,4 +167,16 @@
   return [super performKeyEquivalent:event];
 }
 
+- (BOOL)validateUserInterfaceItem:(id<NSValidatedUserInterfaceItem>)item {
+  return [[self commandHandler] validateUserInterfaceItem:item window:self];

[tapted, 2015/08/28 05:04:02]

(if my other comment doesn't make sense) could these calls instead be something
like

[commandDispatcher_ commandDispatch:sender];

(i.e. CommandDispatcher just assumes its delegate will handle it, and uses
window=owner). Then get rid of setCommandHandler

[jackhou1, 2015/09/03 01:12:49]

It feels unnecessary for these methods to go through CommandDispatcher. And the
fact that ChromeCommandDispatcherDelegate is also
UserInterfaceItemCommandHandler is just a convenient implementation detail. They
don't really need to be coupled. In fact, we could even move
UserInterfaceItemCommandHandler to another file.

BTW, in patch set 4, setCommandHandler is only on NativeWidgetMacNSWindow, and
CEPW calls
[commandDispatcherDelegate_ validate...]

+}
+
+- (void)commandDispatch:(id)sender {
+  [[self commandHandler] commandDispatch:sender window:self];
+}
+
+- (void)commandDispatchUsingKeyModifiers:(id)sender {
+  [[self commandHandler] commandDispatchUsingKeyModifiers:sender window:self];
+}
+
 @end