[Mac] Move UI item validation to UserInterfaceItemCommandHandler.

ui/views/cocoa/native_widget_mac_nswindow.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/native_widget_mac_nswindow.h"

[tapted, 2015/08/27 07:24:42]

the header should change too right...? (to implement the protocol)

[jackhou1, 2015/09/03 01:12:49]

Done.

In patch set 3 it wasn't necessary for NativeWidgetMacNSWindow to implement
NSUserInterfaceValidations because it was implied by implementing
CommandDispatchingWindow.

 
 #include "base/mac/foundation_util.h"
 #import "ui/views/cocoa/views_nswindow_delegate.h"
 #include "ui/views/controls/menu/menu_controller.h"
 #include "ui/views/widget/native_widget_mac.h"
 #include "ui/views/widget/widget_delegate.h"
 
 @interface NativeWidgetMacNSWindow ()
 - (ViewsNSWindowDelegate*)viewsNSWindowDelegate;
 - (views::Widget*)viewsWidget;
@@ skipping 134 matching lines @@
 
   NSCursor* cursor = [[self viewsNSWindowDelegate] cursor];
   if (cursor)
     [cursor set];
   else
     [super cursorUpdate:theEvent];
 }
 
 // CommandDispatcher implementation.
 
+@synthesize commandHandler;
+
 - (BOOL)redispatchKeyEvent:(NSEvent*)event {
   return [commandDispatcher_ redispatchKeyEvent:event];
 }
 
 - (BOOL)defaultPerformKeyEquivalent:(NSEvent*)event {
   return [super performKeyEquivalent:event];
 }
 
+- (BOOL)validateUserInterfaceItem:(id<NSValidatedUserInterfaceItem>)item {
+  return [[self commandHandler] validateUserInterfaceItem:item window:self];

[tapted, 2015/08/28 05:04:02]

(if my other comment doesn't make sense) could these calls instead be something
like

[commandDispatcher_ commandDispatch:sender];

(i.e. CommandDispatcher just assumes its delegate will handle it, and uses
window=owner). Then get rid of setCommandHandler

[jackhou1, 2015/09/03 01:12:49]

It feels unnecessary for these methods to go through CommandDispatcher. And the
fact that ChromeCommandDispatcherDelegate is also
UserInterfaceItemCommandHandler is just a convenient implementation detail. They
don't really need to be coupled. In fact, we could even move
UserInterfaceItemCommandHandler to another file.

BTW, in patch set 4, setCommandHandler is only on NativeWidgetMacNSWindow, and
CEPW calls
[commandDispatcherDelegate_ validate...]

+}
+
+- (void)commandDispatch:(id)sender {
+  [[self commandHandler] commandDispatch:sender window:self];
+}
+
+- (void)commandDispatchUsingKeyModifiers:(id)sender {
+  [[self commandHandler] commandDispatchUsingKeyModifiers:sender window:self];
+}
+
 @end