Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2350)

Unified Diff: chrome/browser/ui/cocoa/browser_window_command_handler.h

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute
Patch Set: Split out BrowserWindowCommandHandler and only use it in browser windows. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_command_handler.h
diff --git a/chrome/browser/ui/cocoa/browser_window_command_handler.h b/chrome/browser/ui/cocoa/browser_window_command_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..08d1a07bd1c5a98d7402da6baab3c52b9096ab78
--- /dev/null
+++ b/chrome/browser/ui/cocoa/browser_window_command_handler.h
@@ -0,0 +1,18 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COMMAND_HANDLER_H_
+#define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COMMAND_HANDLER_H_
+
+#import <Cocoa/Cocoa.h>
tapted 2015/09/04 02:56:24 nit: Foundation/Foundation.h for NSObject
jackhou1 2015/09/04 06:13:58 Done.
+
+#import "ui/base/cocoa/command_dispatcher.h"
+
+// Implement UserInterfaceItemCommandHandler by validating items using global
+// chrome:: functions and executing commands with chrome::ExecuteCommand().
+@interface BrowserWindowCommandHandler
+ : NSObject<UserInterfaceItemCommandHandler>
tapted 2015/09/04 02:56:24 I wonder... does this even need to be NSObject? Ca
jackhou1 2015/09/04 06:13:58 It can be C++, but I'm not sure if there's much be
+@end
+
+#endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COMMAND_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698