chrome/browser/ui/cocoa/browser_window_command_handler.h - Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_command_handler.h

Issue 1250403002: [Mac] Move UI item validation to UserInterfaceItemCommandHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commandexecute

Patch Set: Split out BrowserWindowCommandHandler and only use it in browser windows. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COMMAND_HANDLER_H_

	6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COMMAND_HANDLER_H_

	7

	8 #import <Cocoa/Cocoa.h>
	tapted 2015/09/04 02:56:24 nit: Foundation/Foundation.h for NSObject nit: Foundation/Foundation.h for NSObject jackhou1 2015/09/04 06:13:58 Done. Show quoted text On 2015/09/04 02:56:24, tapted wrote: > nit: Foundation/Foundation.h for NSObject Done.
	9

	10 #import "ui/base/cocoa/command_dispatcher.h"

	11

	12 // Implement UserInterfaceItemCommandHandler by validating items using global

	13 // chrome:: functions and executing commands with chrome::ExecuteCommand().

	14 @interface BrowserWindowCommandHandler

	15 : NSObject<UserInterfaceItemCommandHandler>
	tapted 2015/09/04 02:56:24 I wonder... does this even need to be NSObject? Ca I wonder... does this even need to be NSObject? Can we just use C++ interfaces? I don't know if that's better... jackhou1 2015/09/04 06:13:58 It can be C++, but I'm not sure if there's much be Show quoted text On 2015/09/04 02:56:24, tapted wrote: > I wonder... does this even need to be NSObject? Can we just use C++ interfaces? > I don't know if that's better... It can be C++, but I'm not sure if there's much benefit. Most of the code surrounding it is ObjC.
	16 @end

	17

	18 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COMMAND_HANDLER_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_command_handler.mm » ('j') | chrome/browser/ui/cocoa/browser_window_command_handler.mm » ('J')