tests/standalone/io/socket_close_test.dart - Issue 12504006: Make IOSink implement StringSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/socket_close_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed second round of review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/standalone/io/socket_close_test.dart

diff --git a/tests/standalone/io/socket_close_test.dart b/tests/standalone/io/socket_close_test.dart

index 4d72f3c9773d0c5b81e1e16302c7d38e246a16e7..a48f5e8bbaf4eb70a8e98e15b06a49f4853134f7 100644

--- a/tests/standalone/io/socket_close_test.dart

+++ b/tests/standalone/io/socket_close_test.dart

@@ -101,7 +101,7 @@ class SocketClose {

onError: (error) => errorHandler(socket));

void writeHello() {

- socket.add("Hello".codeUnits);

+ socket.write("Hello");

}

_iterations++;

@@ -224,7 +224,7 @@ class SocketCloseServer {

}

void writeHello() {

- connection.add("Hello".codeUnits);

+ connection.write("Hello");

}

void dataHandler(bytes) {