tests/standalone/io/secure_socket_test.dart - Issue 12504006: Make IOSink implement StringSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/secure_socket_test.dart

Issue 12504006: Make IOSink implement StringSink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed second round of review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/standalone/io/secure_socket_test.dart

diff --git a/tests/standalone/io/secure_socket_test.dart b/tests/standalone/io/secure_socket_test.dart

index abe27b1e745780599f55aaa8bffddb488f311e16..0fe4c55da3459f8944020058405de27222daecc9 100644

--- a/tests/standalone/io/secure_socket_test.dart

+++ b/tests/standalone/io/secure_socket_test.dart

@@ -22,7 +22,7 @@ Future<HttpServer> startServer() {

onDone: () {

request.response.contentLength = 100;

for (int i = 0; i < 10; i++) {

- request.response.add([0, 1, 2, 3, 4, 5, 6, 7, 8, 9]);

+ request.response.writeBytes([0, 1, 2, 3, 4, 5, 6, 7, 8, 9]);

}

request.response.close();

});

@@ -43,7 +43,7 @@ void main() {

List<int> body = <int>[];

startServer().then((server) {

SecureSocket.connect("localhost", server.port).then((socket) {

- socket.add("GET / HTTP/1.0\r\nHost: localhost\r\n\r\n".codeUnits);

+ socket.write("GET / HTTP/1.0\r\nHost: localhost\r\n\r\n");

socket.close();

socket.listen(

(List<int> data) {