chrome/chrome_browser.gypi - Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 803f2b26a6b96dafd9511e7addf14b1a9ad3f41d..6c43c0a17c78cd5a8309fa114ec8d6e60d3d5268 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1704,6 +1704,8 @@

'browser/signin/signin_global_error.h',

'browser/signin/signin_internals_util.cc',

'browser/signin/signin_internals_util.h',

+ 'browser/signin/signin_manager_base.cc',

+ 'browser/signin/signin_manager_base.h',

'browser/signin/signin_manager.cc',

'browser/signin/signin_manager.h',

Roger Tawa OOO till Jul 10th 2013/03/27 17:36:33 don't you need to add lines below that now exlude

tim (not reviewing) 2013/03/29 18:03:16 Yes, but I was doing this in two steps (see my com

'browser/signin/signin_manager_cookie_helper.cc',

« chrome/browser/signin/signin_manager_factory.h ('K') | « chrome/browser/signin/signin_manager_factory.cc ('k') | no next file » | no next file with comments »