signin: pull basic SigninManager functionality into new SigninManagerBase class.

chrome/chrome_browser.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser',
       'type': 'static_library',
       'variables': { 'enable_wexit_time_destructors': 1, },
@@ skipping 1686 matching lines @@
         'browser/signin/oauth2_token_service.cc',
         'browser/signin/oauth2_token_service.h',
         'browser/signin/oauth2_token_service_factory.cc',
         'browser/signin/oauth2_token_service_factory.h',
         'browser/signin/oauth2_token_service_request.cc',
         'browser/signin/oauth2_token_service_request.h',
         'browser/signin/signin_global_error.cc',
         'browser/signin/signin_global_error.h',
         'browser/signin/signin_internals_util.cc',
         'browser/signin/signin_internals_util.h',
+        'browser/signin/signin_manager_base.cc',
+        'browser/signin/signin_manager_base.h',
         'browser/signin/signin_manager.cc',
         'browser/signin/signin_manager.h',

[Roger Tawa OOO till Jul 10th, 2013/03/27 17:36:33]

don't you need to add lines below that now exlude signin_manager.cc|h from
chromeos builds?

[tim (not reviewing), 2013/03/29 18:03:16]

Yes, but I was doing this in two steps (see my comment in
signin_manager_factory).  I'll try to combine it now though.

         'browser/signin/signin_manager_cookie_helper.cc',
         'browser/signin/signin_manager_cookie_helper.h',
         'browser/signin/signin_manager_factory.cc',
         'browser/signin/signin_manager_factory.h',
         'browser/signin/signin_names_io_thread.cc',
         'browser/signin/signin_names_io_thread.h',
         'browser/signin/signin_tracker.cc',
         'browser/signin/signin_tracker.h',
         'browser/signin/signin_ui_util.cc',
         'browser/signin/signin_ui_util.h',
@@ skipping 1385 matching lines @@
             'package_name': 'org/chromium/chrome/browser/ui/toolbar',
             'template_deps': ['browser/ui/toolbar/toolbar_model_security_level_list.h'],
           },
           'includes': [ '../build/android/java_cpp_template.gypi' ],
         },
       ],
      },
     ],
   ],
 }