Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3449)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix override Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
index e879b6e54422139c580a5e873164852a5dd4ea41..a506ff19622248f947bd56141f5891af52dcdc40 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_io_data.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/signin/signin_manager.h"
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/signin/signin_manager_fake.h"
#include "chrome/browser/signin/signin_names_io_thread.h"
@@ -53,8 +54,8 @@ const char kImplicitURLString[] =
class SigninManagerMock : public FakeSigninManager {
public:
- explicit SigninManagerMock(Profile* profile)
- : FakeSigninManager(profile) {}
+ explicit SigninManagerMock(Profile* profile) : FakeSigninManager(profile) {
+ }
MOCK_CONST_METHOD1(IsAllowedUsername, bool(const std::string& username));
};
@@ -266,10 +267,10 @@ void OneClickSigninHelperTest::CreateSigninManager(
profile_, BuildSigninManagerMock));
if (signin_manager_)
signin_manager_->SetSigninProcess(trusted_signin_process_id_);
+
if (!username.empty()) {
ASSERT_TRUE(signin_manager_);
- signin_manager_->StartSignIn(username, std::string(), std::string(),
- std::string());
+ signin_manager_->SetAuthenticatedUsername(username);
}
}

Powered by Google App Engine
This is Rietveld 408576698