Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix override Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/sync/profile_sync_service_startup_unittest.cc ('K') | « chrome/browser/ui/auto_login_prompter.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index fe9300c4ef4c42bed3a2b6cdabbcb2ce48b8a0b0..dea0fe6b562a2f6d5bcdbd772149cb462e4333b5 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -192,7 +192,7 @@ void ShowSearchEngineSettings(Browser* browser) {
void ShowBrowserSignin(Browser* browser, SyncPromoUI::Source source) {
Profile* original_profile = browser->profile()->GetOriginalProfile();
- SigninManager* manager =
+ SigninManagerBase* manager =
SigninManagerFactory::GetForProfile(original_profile);
DCHECK(manager->IsSigninAllowed());
// If we're signed in, just show settings.
« chrome/browser/sync/profile_sync_service_startup_unittest.cc ('K') | « chrome/browser/ui/auto_login_prompter.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698