chrome/browser/sync/sync_global_error.h - Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_global_error.h

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix override Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/profile_sync_service_startup_unittest.cc ('K') | « chrome/browser/sync/profile_sync_service_unittest.cc ('k') | chrome/browser/sync/sync_global_error.cc » ('j') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sync_global_error.h

diff --git a/chrome/browser/sync/sync_global_error.h b/chrome/browser/sync/sync_global_error.h

index 8b9c2f2e0937e2abde638cf3e1488e51f9eb39e5..cd4108463aa35d771ecb1afae138d5290c277d23 100644

--- a/chrome/browser/sync/sync_global_error.h

+++ b/chrome/browser/sync/sync_global_error.h

@@ -11,14 +11,14 @@

#include "chrome/browser/ui/global_error/global_error.h"

class ProfileSyncService;

-class SigninManager;

+class SigninManagerBase;

// Shows sync errors on the wrench menu using a bubble view and a

// menu item.

class SyncGlobalError : public GlobalError,

public ProfileSyncServiceObserver {

public:

- SyncGlobalError(ProfileSyncService* service, SigninManager* signin);

+ SyncGlobalError(ProfileSyncService* service, SigninManagerBase* signin);

virtual ~SyncGlobalError();

virtual bool HasMenuItem() OVERRIDE;

@@ -43,7 +43,7 @@ class SyncGlobalError : public GlobalError,

string16 bubble_message_;

string16 menu_label_;

ProfileSyncService* service_;

- SigninManager* signin_;

+ SigninManagerBase* signin_;

DISALLOW_COPY_AND_ASSIGN(SyncGlobalError);

};