Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: chrome/browser/sync/profile_sync_service_unittest.cc

Issue 12502017: signin: pull basic SigninManager functionality into new SigninManagerBase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix override Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_unittest.cc b/chrome/browser/sync/profile_sync_service_unittest.cc
index ae453581ffb928aee4c195e5a76cf393284fb56e..2d7f837ac854f18ffd75df4871b11420b7cc8abc 100644
--- a/chrome/browser/sync/profile_sync_service_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_unittest.cc
@@ -103,7 +103,7 @@ class ProfileSyncServiceTestHarness {
bool sync_setup_completed,
syncer::StorageOption storage_option) {
if (!service.get()) {
- SigninManager* signin =
+ SigninManagerBase* signin =
SigninManagerFactory::GetForProfile(profile.get());
signin->SetAuthenticatedUsername("test");
ProfileSyncComponentsFactoryMock* factory =
@@ -183,7 +183,7 @@ class ProfileSyncServiceTest : public testing::Test {
};
TEST_F(ProfileSyncServiceTest, InitialState) {
- SigninManager* signin =
+ SigninManagerBase* signin =
SigninManagerFactory::GetForProfile(harness_.profile.get());
harness_.service.reset(new TestProfileSyncService(
new ProfileSyncComponentsFactoryMock(),
@@ -217,7 +217,7 @@ TEST_F(ProfileSyncServiceTest, DisabledByPolicy) {
harness_.profile->GetTestingPrefService()->SetManagedPref(
prefs::kSyncManaged,
Value::CreateBooleanValue(true));
- SigninManager* signin =
+ SigninManagerBase* signin =
SigninManagerFactory::GetForProfile(harness_.profile.get());
harness_.service.reset(new TestProfileSyncService(
new ProfileSyncComponentsFactoryMock(),
@@ -230,7 +230,7 @@ TEST_F(ProfileSyncServiceTest, DisabledByPolicy) {
}
TEST_F(ProfileSyncServiceTest, AbortedByShutdown) {
- SigninManager* signin =
+ SigninManagerBase* signin =
SigninManagerFactory::GetForProfile(harness_.profile.get());
signin->SetAuthenticatedUsername("test");
ProfileSyncComponentsFactoryMock* factory =
@@ -255,7 +255,7 @@ TEST_F(ProfileSyncServiceTest, AbortedByShutdown) {
}
TEST_F(ProfileSyncServiceTest, DisableAndEnableSyncTemporarily) {
- SigninManager* signin =
+ SigninManagerBase* signin =
SigninManagerFactory::GetForProfile(harness_.profile.get());
signin->SetAuthenticatedUsername("test");
ProfileSyncComponentsFactoryMock* factory =
@@ -290,7 +290,7 @@ TEST_F(ProfileSyncServiceTest, DisableAndEnableSyncTemporarily) {
}
TEST_F(ProfileSyncServiceTest, EnableSyncAndSignOut) {
- SigninManager* signin =
+ SigninManagerBase* signin =
SigninManagerFactory::GetForProfile(harness_.profile.get());
signin->SetAuthenticatedUsername("test@test.com");
ProfileSyncComponentsFactoryMock* factory =

Powered by Google App Engine
This is Rietveld 408576698