Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1250123002: Fixed bug in story_runner's has_existing_exception. (Closed)

Created:
5 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed bug in story_runner's has_existing_exception. sys.exc_info() returns a tuple of (None, None, None) to indicate that no exception is currently being handled. Comparing this against None always returns true, so exceptions thrown in DidRunStory are silently being squelched. This change has been tested with some forthcoming tests, but otherwise there's no test coverage for this fix yet. (There's also no test coverage of the existing code path, hence the bug.) BUG=495870 Committed: https://crrev.com/86984d5fc56ce00e7b37ebe798aefa1d5374c83e Cr-Commit-Position: refs/heads/master@{#339971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/internal/story_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Russell (switch to Gerrit)
Please review. I'd like to split this fix off from my forthcoming CL since the ...
5 years, 5 months ago (2015-07-22 20:13:25 UTC) #2
aiolos (Not reviewing)
lgtm
5 years, 5 months ago (2015-07-22 20:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250123002/1
5 years, 5 months ago (2015-07-22 20:19:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 23:06:20 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 23:06:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86984d5fc56ce00e7b37ebe798aefa1d5374c83e
Cr-Commit-Position: refs/heads/master@{#339971}

Powered by Google App Engine
This is Rietveld 408576698